Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 towards fixing the typetest-oldest-supported-numpy CI job #289

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

jorenham
Copy link
Owner

@jorenham jorenham commented Dec 9, 2024

apparently mypy was still using the latest numpy because it doesn't understand editable projects and has to be run in an isolated uv env which doesn't include the uv pip install'ed numpy version or the correct python version

@jorenham jorenham added meta: CI Continuous integration topic: uv labels Dec 9, 2024
@jorenham jorenham added this to the 1.14.1.6 milestone Dec 9, 2024
@jorenham jorenham force-pushed the fix-typetest-oldest-supported-numpy branch from 0f57952 to 1fd5c67 Compare December 9, 2024 18:36
@jorenham
Copy link
Owner Author

jorenham commented Dec 9, 2024

@miloth @wolph any thoughts on this? It's horribly ugly, but at least it actually works now 😅

@jorenham
Copy link
Owner Author

jorenham commented Dec 9, 2024

I'm gonna merge this as a temporary fix that will be properly fixed by #285

@jorenham jorenham merged commit c48ee75 into master Dec 9, 2024
6 checks passed
@jorenham jorenham deleted the fix-typetest-oldest-supported-numpy branch December 9, 2024 20:16
@jorenham jorenham mentioned this pull request Dec 9, 2024
3 tasks
@wolph
Copy link
Contributor

wolph commented Dec 9, 2024

@miloth @wolph any thoughts on this? It's horribly ugly, but at least it actually works now 😅

Won't my pull request be able to automatically fix this because it runs the separate environments already?

@jorenham
Copy link
Owner Author

jorenham commented Dec 9, 2024

Won't my pull request be able to automatically fix this because it runs the separate environments already?

Well, no, because otherwise the CI would have been failing, as there are a bunch of numpy<1.24 errors after all (see e.g. #292) 😅

And this one also didn't fix it, but #290 did 🤷🏻

@jorenham jorenham changed the title 💚 fix typetest-oldest-supported-numpy CI job 💚 towards fixing the typetest-oldest-supported-numpy CI job Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: CI Continuous integration topic: uv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants