-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use faster-than-regex .substring() slicing #84
Conversation
Improve runtime performance when clearing bleeding sequences.
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 133 147 +14
=========================================
+ Hits 133 147 +14
Continue to review full report at Codecov.
|
Add mentions about inspiration to docs? |
@jorgebucaran I think that's a good idea. Let's add a section dedicated to credits and honourable mentions. |
That's a great idea. Done in 6a4a871! 💯 |
@jorgebucaran 6a4a871 will be better by adding explicit link to |
I'm pretty happy with the result, actually, but I'll definitely consider your suggestion. Thanks! |
The acknowledgment sounds like it was my contribution to this project, which it wasn’t. I don’t mind adopting performance tricks. I would really appreciate if you could update this section with proper links to the projects. Would be even better if the section wasn’t buried somewhere down the page. Thanks |
Sure, I can think of another way to acknowledge you. 👌 |
@alexeyraspopov We ended up listing reference in release notes next to a specific change, which seems more appropriate, since this is a one-off optimization and not something fundamental to how Colorette is built. |
I’d prefer adding links to the projects, as I mentioned previously. |
Yup, we are adding links for sure, give us a bit of time :) |
Absolutely. Added in ada9fb3. 👍 |
This improves runtime performance when clearing bleeding sequences, using
.substring()
rather than regexes.This clever idea is inspired by @alexeyraspopov's
replaceClose
function in picocolors. Thank you for that! 🙌