Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added cargo check to benchmarks #730

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

sundy-li
Copy link
Collaborator

@sundy-li sundy-li commented Jan 4, 2022

After #717

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #730 (2a68504) into main (9b54146) will increase coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   70.35%   70.52%   +0.17%     
==========================================
  Files         311      311              
  Lines       16920    16920              
==========================================
+ Hits        11904    11933      +29     
+ Misses       5016     4987      -29     
Impacted Files Coverage Δ
benches/arithmetic_kernels.rs 0.00% <ø> (ø)
benches/filter_kernels.rs 0.00% <0.00%> (ø)
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (+1.49%) ⬆️
src/io/csv/write/serialize.rs 60.77% <0.00%> (+11.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b54146...2a68504. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did not know this was possible xD

Cargo.toml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Jan 4, 2022
@jorgecarleitao jorgecarleitao merged commit 7add9d3 into jorgecarleitao:main Jan 4, 2022
@jorgecarleitao jorgecarleitao changed the title Add benchmark check Added cargo check to benchmarks Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants