Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returned <script> tags are not executed #4

Closed
omitter opened this issue Feb 20, 2019 · 3 comments · Fixed by #6
Closed

Returned <script> tags are not executed #4

omitter opened this issue Feb 20, 2019 · 3 comments · Fixed by #6

Comments

@omitter
Copy link

omitter commented Feb 20, 2019

If a response contains script tags they are not executed, in contrast to usual Turbolinks responses.

It looks like activateBodyScriptElements here would do the job, but I couldn't get it to run (also can't see why it's in ErrorRenderer…).

@jorgemanrubia
Copy link
Owner

Thanks for reporting this @omitter and for the potential solution. I'll see if I can fix this shortly.

@jorgemanrubia
Copy link
Owner

Hi @omitter,

This was fixed in version 0.9.9. I changed the internals quite a bit in this version, I'd appreciate if you can confirm all is good on your end. Thanks 🙏

Cheers

@omitter
Copy link
Author

omitter commented Feb 25, 2019

I did a quick test and with 0.9.10 it's working fine. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants