-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite using Rails middleware #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is more robust because it is not dependant on how responses are rendered.
jorgemanrubia
changed the title
[WIP] Rewrite using Rails middleware
Rewrite using Rails middleware
Feb 24, 2019
This was referenced Feb 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of patching ‘render’, the engine now configures a rack middleware to analyze requests and modify responses.
This is much more robust since it is now independent of how the
render
method is invoked (or if it's invoked at all).This will handle errors consistently now in both development and production mode. For development mode, I still had to patch
ActionDispatch::DebugExceptions
to discriminate remote requests we want to handle with turbolinks.Fix Handling 500s #1. Big kudos to @excid3 for his help on this one. In particular, his approach of using
document.open/write/close
fixed Returned <script> tags are not executed #4 as a very nice side effect 🙏😬.Fix Returned <script> tags are not executed #4
UPDATE: it's performing a full
html
replace now. See #7. Fixed in #8Pending
<script>
in responses are executed