Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better docstring detection when folding #1776

Merged
merged 3 commits into from
May 1, 2020

Conversation

galaunay
Copy link
Collaborator

PR Summary

Follow #1774.

In the folding module, we use elpy-info-docstring-p to check if the cursor in on a docstring.
python-info-docstring-p does a way better job at that, and there is no reason (anymore ?) not to use it.

PR checklist

Please make sure that the following things have been addressed (and check the relevant checkboxes):

  • Commits respect our guidelines
  • Tests are passing properly (see here on how to run Elpy's tests)

@coveralls
Copy link

coveralls commented Apr 18, 2020

Coverage Status

Coverage remained the same at 92.145% when pulling eb46e8e on galaunay:better-docstring-folding into 816061c on jorgenschaefer:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.145% when pulling 1cf7788 on galaunay:better-docstring-folding into 816061c on jorgenschaefer:master.

@drdv
Copy link

drdv commented Apr 18, 2020

Thanks, this is a nice change and it permits cleaning up other things as well. I would like to suggest another modification related to hiding docstrings. I am not, however, sure what would be the most convenient way for making a PR that depends on this PR.

@drdv drdv mentioned this pull request Apr 18, 2020
@drdv drdv mentioned this pull request Apr 19, 2020
3 tasks
@gopar
Copy link
Collaborator

gopar commented Apr 22, 2020

LGTM

Sorry I haven't active :(

@galaunay galaunay merged commit 7e8181d into jorgenschaefer:master May 1, 2020
@drdv drdv mentioned this pull request Jun 7, 2020
4 tasks
@galaunay galaunay deleted the better-docstring-folding branch November 15, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants