Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large refactoring/rewrite #14

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

Large refactoring/rewrite #14

wants to merge 66 commits into from

Conversation

leifg
Copy link

@leifg leifg commented Apr 22, 2013

Here are the changes:

  • add MIT License (kept the original copyright notices)
  • bump API version to 27.0
  • separate HTTP and CSV handling
  • correctly handle Array values as multi picklists (see Updating picklist in Array format #10)
  • add testing and code metrics (travis-ci, codeclimate, coveralls)
  • rename create to insert (to make it consistent with the salesforce bulk API naming)
  • refactor behaviour of wait flag

Still WIP, let me know what you think

Leif Gensert and others added 30 commits April 8, 2013 17:25
add path for bundler in .gitignore
032a2bd
start rewrite and introduce JobStatus object
e96237a
streamline quotes
76d5c0a
omit temp directory
d070b64
grand refactoring (part 1)
faf87f2
rename JobStatus to BatchStatus
c79f3e8
remove job object
7bc1bc4
remove debug output
3e70288
make ready for travis
7fd993d
add coveralls
0fd7461
refactoring the HTTP connections
a071e7d
@leifg
fix tests for 1.9.3
52ad1d3
correctly implement http_wrapper
f41a751
rename login method
3697d25
remove debug output
f63fe68
dispatch close_job correctly
38b155f
refactor connection to use new http api
b8a8b88
remove duplicate spec_helper
90f03d7
remove batch_status wrapper
a1a3682
remove debug prompt
45e17b6
remove old request class
07c38d2
remove xmlsimple dependency
817aed3
refactor connection handling from batch
661d6b4
better spec naming
2347bec
proper name internal method
fa6ad2e
implement query
56c3080
simplify conversion of data
74a5ea8 
simplify conversion of csv table
fix reference bug
3900407
handle query and operations correctly
4a3d87e
remove newline
d84a920
Leif Gensert added 29 commits April 21, 2013 11:11
add test for batch#final_status
c52758d
add test for batch#final_status to test -1 batch_id
6d2de8d
add test for batch#final_status to test querying to salesforce
4f8b998
add pending test for test of yielding
cda777a
add test for connection
e37de55
add tests for salesforce_bulk
01dbbb5
add pending test for multi picklist
86050b6
add test for worfkflow of salesforce bulk
715e440
remove TODOs and add tests for yielding
3805854
remove TODO
6c1e842
add test for failing batch
e4672eb
remove TODO
ae66a30
add workflow test for query
ebb9c85
implement correct behaviour for multi picklists
d88d6af
add MIT license
4319965
rewrite README
e5d7e00
typo
771a3d5
test yielding in SalesforceBulk::Batch
7bc70ef
set version to 2.0
05f5b65
fix the only method, that wasn't tested
22d92ed
add rubinius to test matrix
fe84423
remove spec files from coverage
12dcce3
make quotes consistent
d77a690
fix bug that prevents importing a single record
b4825dd
remove already ignored file
e69de13
add pending test for spaces in query values
acddd8a
fix bug that striped spaces in query result
d045db1
better passing of splat
f362091
correctly parse instance for new return value of salesforce response
4cc05f5
@leifg
Copy link
Author

leifg commented May 13, 2013

As there is no reaction to this pull requet. I released it under a different name (Copyright and Commit logs have been retained)

https://github.com/propertybase/executrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leifg