Fix exception in ConsoleRender when property has been removed #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ConsoleRender` failed to resolve component schemas which had been removed in the "new" OpenAPI specification and threw an `IllegalArgumentException`: ``` Unexpected exception. Reason: ref '#/components/schemas/RemovedSchema' doesn't exist. java.lang.IllegalArgumentException: ref '#/components/schemas/PermissionSet' doesn't exist. at com.qdesrame.openapi.diff.core.utils.RefPointer.resolveRef(RefPointer.java:20) at com.qdesrame.openapi.diff.core.output.ConsoleRender.resolve(ConsoleRender.java:231) at com.qdesrame.openapi.diff.core.output.ConsoleRender.lambda$properties$1(ConsoleRender.java:217) at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684) at com.qdesrame.openapi.diff.core.output.ConsoleRender.properties(ConsoleRender.java:216) at com.qdesrame.openapi.diff.core.output.ConsoleRender.incompatibilities(ConsoleRender.java:199) at com.qdesrame.openapi.diff.core.output.ConsoleRender.lambda$incompatibilities$0(ConsoleRender.java:202) at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684) at com.qdesrame.openapi.diff.core.output.ConsoleRender.incompatibilities(ConsoleRender.java:202) at com.qdesrame.openapi.diff.core.output.ConsoleRender.incompatibilities(ConsoleRender.java:185) at com.qdesrame.openapi.diff.core.output.ConsoleRender.itemContent(ConsoleRender.java:179) at com.qdesrame.openapi.diff.core.output.ConsoleRender.ul_content(ConsoleRender.java:155) at com.qdesrame.openapi.diff.core.output.ConsoleRender.ol_changed(ConsoleRender.java:87) at com.qdesrame.openapi.diff.core.output.ConsoleRender.render(ConsoleRender.java:47) at com.qdesrame.openapi.diff.cli.Main.main(Main.java:159) ```
joschi
force-pushed
the
console-render-missing-property
branch
from
b3b1d99
to
6daa385
Compare
joschi
added a commit
that referenced
this pull request
Jun 24, 2020
`HtmlRender` and `MarkdownRender` failed to resolve component schemas which had been removed in the "new" OpenAPI specification and threw an `IllegalArgumentException`. Refs #7
joschi
added a commit
that referenced
this pull request
Jun 24, 2020
`HtmlRender` and `MarkdownRender` failed to resolve component schemas which had been removed in the "new" OpenAPI specification and threw an `IllegalArgumentException`. Refs #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsoleRenderfailed to resolve component schemas which had been removed in the "new" OpenAPI specification and threw anIllegalArgumentException: