fix: Add test for precision in options arg of eigs

And also a fix for a small bug that the new test uncovered.
josdejong · Oct 5, 2023 · 6d9f759 · 6d9f759
1 parent e19e555
commit 6d9f759
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/function/matrix/eigs/complexEigs.js b/src/function/matrix/eigs/complexEigs.js
@@ -150,7 +150,7 @@ export function createComplexEigs ({ addScalar, subtract, flatten, multiply, mul
     }
 
     // return the diagonal row transformation matrix
-    return diag(Rdiag)
+    return findVectors ? diag(Rdiag) : null
   }
 
   /**

diff --git a/test/unit-tests/function/matrix/eigs.test.js b/test/unit-tests/function/matrix/eigs.test.js
@@ -243,6 +243,9 @@ describe('eigs', function () {
     // only one.
     const poorm = eigs(matrix(difficult), 1e-14)
     assert.deepStrictEqual(poorm.values.size(), [3])
+    // Make sure the precision argument can go in the options object
+    const stillbad = eigs(difficult, { precision: 1e-14, eigenvectors: false })
+    assert.deepStrictEqual(stillbad.values, poor.values)
   })
 
   it('diagonalizes matrix with bigNumber', function () {
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         // return the diagonal row transformation matrix
-        return diag(Rdiag)
+        return findVectors ? diag(Rdiag) : null
       }
       /**
@@ Expand Down @@