Refactor the API to use undefined
instead of null
#453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: the API currently has a mix of
null
andundefined
. To unify this, we will useundefined
everywhere. This works better thannull
sinceundefined
is the "default" in JavaScript, for example with optional chainging, missing properties, empty array slots, function argument defaults. Also:null
is a valid JSON value, so for theContent.json
type we must useundefined
when there is no JSON.This is a breaking change in the following properties and methods:
selection
onChange
(contentErrors
andpatchResult
properties)onRenderContextMenu
(selection
property)onSelect
validate
(returnsundefined
)select