Maintain history when switching mode #504

josdejong · 2024-11-25T15:12:54Z

Currently, when switching mode, you lose all your history. This makes it an unsafe action.

This PR lets the editor maintain history when switching modes:

Creates a custom history for the codemirror editor (text mode), controlled by TextMode
Moves the history to JSONEditorRoot, maintaining a single history for all three modes.
Adds switching mode as a new history item.
Fixes not being able to change property selection via method updateProps.

josdejong added 14 commits November 20, 2024 09:13

chore: replace codemirror history with a self-managed history (WIP)

8c8326b

chore: finish the custom history in text mode

b757134

chore: work out the type definitions of TextHistoryItem

4001c6b

chore: cleanup some logging

7ba1909

chore: rename historyAnnotation

0b79f15

chore: move history from the modes to JSONEditorRoot (WIP)

ad84c1f

chore: refactor the history instanced and getter function

848d933

feat: add history item when switching to a different mode

2d984d2

feat: initial scroll via async dispatch

81bde34

fix: text mode doesn't scroll to initial selection

9e2ae3e

fix: flush pending changes in text mode before switching mode

d973e47

chore: add a FIXME to address scrollIntoView on mount in text mode

56804af

fix: cannot set property selection via method updateProps

5bc972c

fix: type import

5503073

josdejong merged commit b5f11ca into main Nov 26, 2024
3 checks passed

josdejong deleted the feat/unified-history branch November 26, 2024 12:07

Provide feedback