Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination for Chrome 22+ when zooming #161

Closed
wants to merge 1 commit into from

Conversation

eunomie
Copy link

@eunomie eunomie commented Nov 29, 2012

Hi,

When using zoom in/out in chrome 22+ with sub-pixel rendering, pages can be cut on the left or right.
A first try to fix it can be found here : #146

This is a new version reducing DOM access by computed webkit scale value only when value is updated (updating zoom fire a window resize event).

I find the code a little dirty because of the addition of a specific value for one engine but I don't how how you handle those cases.

When using zoom in/out in chrome 22+ with sub-pixel rendering,
pages can be cut on the left or right.
A first try to fix it can be found here :
 joseph#146

This is a new version reducing DOM access by computed webkit
scale value only when value is updated (updating zoom fire a
window resize event).
@joseph
Copy link
Owner

joseph commented May 10, 2013

Hi @CrEv and @nono, firstly, thanks again for your contribution, and apologies for not getting onto it promptly. I was hacking on this today, because I thought it might factor in the CSS zoom attribute too. Certainly, when you set body { zoom: 2; } on a document containing a Monocle reader, there will be weird pagination results, but this approach doesn't help there.

I went looking for the component cut-off effect you're both describing in latest Chrome on OSX and Windows, and I couldn't see it. If you know how to reproduce it, and you're willing to test the chrome-zoom branch I just pushed, that would be huge.

I'm going to leave this PR open and close the other one. Thanks again.

@joseph
Copy link
Owner

joseph commented May 10, 2013

FYI in that experimental chrome-zoom branch, I changed the zoom detection function because the old one stopped working in Chrome. See discussion here: tombigel/detect-zoom#37

@eunomie eunomie closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants