ci: migrate linker tests to GHA

Migrate linker tests to Github Actions
josephperrott · Aug 17, 2023 · 66a2f6f · 66a2f6f
1 parent 29112be
commit 66a2f6f
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 43 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -389,44 +389,6 @@ jobs:
       - run: bazel test --build_tag_filters=-e2e --test_tag_filters=-e2e --build_tests_only -- src/...
       - *slack_notify_on_failure
 
-  # ----------------------------------------------------------------------------
-  # Job that runs the AOT linker tests.
-  # ----------------------------------------------------------------------------
-  linker_aot_test:
-    <<: *job_defaults
-    resource_class: xlarge
-    environment:
-      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
-    steps:
-      - checkout_and_rebase
-      - *restore_cache
-      - *setup_bazel_ci_config
-      - *setup_bazel_remote_execution
-      - *yarn_install
-      - *setup_bazel_binary
-
-      - run: yarn test-linker-aot
-      - *slack_notify_on_failure
-
-  # ----------------------------------------------------------------------------
-  # Job that runs the JIT linker tests.
-  # ----------------------------------------------------------------------------
-  linker_jit_test:
-    <<: *job_defaults
-    resource_class: xlarge
-    environment:
-      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
-    steps:
-      - checkout_and_rebase
-      - *restore_cache
-      - *setup_bazel_ci_config
-      - *setup_bazel_remote_execution
-      - *yarn_install
-      - *setup_bazel_binary
-
-      - run: yarn test-linker-jit
-      - *slack_notify_on_failure
-
   # ----------------------------------------------------------------------------
   # Job that runs both AOT and JIT linker tests against Angular snapshot builds.
   # ----------------------------------------------------------------------------
@@ -487,10 +449,6 @@ workflows:
     jobs:
       - bazel_build:
           filters: *ignore_presubmit_branch_filter
-      - linker_aot_test:
-          filters: *ignore_presubmit_branch_filter
-      - linker_jit_test:
-          filters: *ignore_presubmit_branch_filter
       - tests_browsers:
           filters: *ignore_presubmit_branch_filter
       - tests_browserstack:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -103,7 +103,49 @@ jobs:
       - name: Install node modules
         run: yarn install --frozen-lockfile
       - name: Run integration tests
-        run: yarn integration-tests\
+        run: yarn integration-tests
+      # TODO: Set up slack notifications
+      # - name: Running size integration tests (failures are reported in Slack only).
+      #   run: |
+      # If the size integration tests fail, report the failure to a dedicated #components-ci-size-tracking Slack channel.
+      # yarn integration-tests:size-test || yarn ci-notify-slack-failure components-ci-size-tracking
+
+  linker_aot_tests:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Initialize environment
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
+        with:
+          cache-node-modules: true
+      - name: Setup Bazel
+        uses: angular/dev-infra/github-actions/bazel/setup@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
+      - name: Setup Bazel RBE
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
+      - name: Install node modules
+        run: yarn install --frozen-lockfile
+      - name: Run linker AOT tests
+        run: yarn test-linker-aot
+      # TODO: Set up slack notifications
+      # - name: Running size integration tests (failures are reported in Slack only).
+      #   run: |
+      # If the size integration tests fail, report the failure to a dedicated #components-ci-size-tracking Slack channel.
+      # yarn integration-tests:size-test || yarn ci-notify-slack-failure components-ci-size-tracking
+
+  linker_jit_tests:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Initialize environment
+        uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
+        with:
+          cache-node-modules: true
+      - name: Setup Bazel
+        uses: angular/dev-infra/github-actions/bazel/setup@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
+      - name: Setup Bazel RBE
+        uses: angular/dev-infra/github-actions/bazel/configure-remote@9931e1a8d1b62fcd2267e89f9993a494856cc1cd
+      - name: Install node modules
+        run: yarn install --frozen-lockfile
+      - name: Run linker JIT tests
+        run: yarn test-linker-jit
       # TODO: Set up slack notifications
       # - name: Running size integration tests (failures are reported in Slack only).
       #   run: |