-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix round-tripping commits that contain extra headers #1389
Fix round-tripping commits that contain extra headers #1389
Conversation
- Fmt for Oid instead of hex::encode - Into instead of as_bstr() - ByteSlice instead of pointer deref and as_bstr()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I think it's ok to use gix here.
Yeah once I realised (after doing #1387) that it was possible to use What do you want to do about the |
Avoid navigating `--reverse`'s behaviour by just applying two inverse filters explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks a lot!
Thank you @christian-schilling! What's your approach for release schedule. Now that this is fixed, a release including the fix will unblock my team's adoption of JOSH. Is this something that could be done? |
Out approach to release schedule is to release from time to time when major bugs of features where fixed or introduced. But we do run production instances straigt of |
Fixes #1377
Closes #1387
As per #1387 (comment) this is how this might look by using the
gix-object
crate to own the commit object format.