fix ThetaG_JD calculation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ThetaG_JD conversion has a step that converts from Julian date to UT1. This involves taking the fractional part of the Julian date. Instead of taking the fractional component, the calculation would be fixed at 0.5. Fix by using math.Modf
|
Awesome, thanks so much for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ThetaG_JD conversion has a step that converts from Julian date
to UT1. This involves taking the fractional part of the Julian
date. Instead of taking the fractional component, the calculation
would be fixed at 0.5.
Fix by using math.Modf