Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

. #19

Merged
merged 2 commits into from
Jan 8, 2019
Merged

. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f73e28
make internal flag configurable for bastion LB.
jason-instacart Nov 27, 2018
9ddfb04
update README with the new lb_is_internal var
jason-instacart Nov 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ These have been generated with [terraform-docs](https://github.com/segmentio/ter
| lb_healthcheck_port | TCP port to conduct lb target group healthchecks. Acceptable values are 22 or 2222 | string | `2222` | no |
| lb_healthy_threshold | Healthy threshold for lb target group | string | `2` | no |
| lb_interval | interval for lb target group health check | string | `30` | no |
| lb_is_internal | whether the lb will be internal | string | false | no |
| lb_unhealthy_threshold | Unhealthy threshold for lb target group | string | `2` | no |
| route53_zone_id | Route53 zoneId | string | `` | no |
| security_groups_additional | additional security group IDs to attach to host instance | list | `<list>` | no |
Expand Down
2 changes: 1 addition & 1 deletion load_balancer.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
resource "aws_lb" "bastion-service" {
name = "${md5(format("bastion-service-%s",var.vpc))}"
load_balancer_type = "network"
internal = false
internal = "${var.lb_is_internal}"
subnets = ["${var.subnets_lb}"]
enable_cross_zone_load_balancing = true
tags = "${var.tags}"
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ variable "lb_interval" {
default = "30"
}

variable "lb_is_internal" {
type = "string"
description = "whether the lb will be internal"
default = false
}

variable "asg_max" {
type = "string"
description = "Max numbers of bastion-service hosts in ASG"
Expand Down