Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index.js): pass project root options to git fn #5

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

johnleider
Copy link

Initial check wasn't using provided options for
project root causing the plugin to crash

initial check wasn't using provided options for
project root causing the plugin to crash
@johnleider
Copy link
Author

This fix seems to only work locally. still failing on vercel.

@joshuatz
Copy link
Owner

@johnleider Thanks for catching this and opening the PR!

I'm merging this and will push a release (will be v3.1.0), and then separately look into the Vercel issue (I've opened up #7 to track). It might take me a little time to track down, since a quick Google search for documentation on how Vercel exposes git is not turning up much. I'll probably create an account of my own to play around with (I've been meaning to do that anyways).

For verification, is docs-next the repo you are trying to get this working with on Vercel?

@johnleider
Copy link
Author

johnleider commented Aug 17, 2020

Yes that’s the repo for now. I managed to get it to work on vercel with my fork but the created and updated times are all the same. I’ve resorted to manually generating it for now. Ty for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants