-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier #182
Add prettier #182
Conversation
Great work @tobilen! I'll take a look at the stories |
How do you feel about adding |
that'd basically mean modifying source files as a side effect. not sure thats a good idea |
Only those that are already modified in the commit (that's the point of |
im not a big fan of git hooks and husky in general. their main purpose is covered by well set up CI systems, and the automation part can be unexpected and unintuitive. from a more practical standpoint, it apparently breaks a lot of GUI interfaces (typicode/husky#131, typicode/husky#125, lint-staged/lint-staged#151, ghooks-org/ghooks#40) or requires a lot of configuration (ghooks-org/ghooks#18) as well |
Legacy stories work as expected. Please resolve conflicts and update the docs |
… into feature/181 # Conflicts: # src/FlipMove.js # src/dom-manipulation.js # src/prop-converter.js
… into feature/181 # Conflicts: # src/FlipMove.js # src/dom-manipulation.js # src/prop-converter.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge as soon as CI passes
By the way, you can now create branches directly in |
alright, thanks. cant merge myself though, no write access. |
Oh, looks like you haven't accepted the invite, please check your email |
Woohoo! Awesome work :D |
adresses #181
yarn eslint:fix
/npm run eslint:fix
)The biggest part is the refactoring of the github issue and legacy stories. I was a bit unsure about refactoring the legacy stories. So maybe take an extra good look at those.