update: prioritise atomic units to prefixed units #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduced Unitwise::Expression::AtomicParser into Unitwise::Expression::Decomposer - additional tests - some refactoring to adhere to rubocop style recommendations
|
This seems pretty reasonable. I'd wager that the number of people attempting to parse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all I'd like to thank you for making this fantastic gem. I've been trialing this gem for basic unit conversions, and it's worked out great for me so far.
Because I'm using this gem for basic unit parsing, I had the same issue as #16, where parsing
'ft'gave me backfemto tonneinstead of the desired unitfoot. This PR is intended to change that so exact atomic unit matches are prioritised over prefixed matches.Obviously this breaks the original parsing precedence of metric > rest, and may not be what you desire. Maybe we can add a configuration object for toggling the parsing precedence?