This repository has been archived by the owner on May 4, 2018. It is now read-only.
unix: don't abort if mutex init fails #1524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of SIGABRT when mutex init fails gracefully return an error code and cleanup.
|
Please drop braces for single statement conditionals. |
|
sorry, every other project I work on requires them due to things like the Apple double-goto SSL bug :) Has been fixed |
|
|
||
| if (pthread_mutexattr_destroy(&attr)) | ||
| abort(); | ||
| err = pthread_mutexattr_destroy(&attr); |
|
The whole mutex / semaphore / condvar code is filled with aborts, I'd rather handle them all in a single go than have some functions abort and some return proper errors. As a result, some APIs might need to return int, since now they return void. |
|
hmm... so maybe I should abandon this until a 2.x version? |
|
Just send the PR against master, work on it, and we'll merge it when ready. No rush :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of SIGABRT when mutex init fails gracefully return an error code
and cleanup.
Related to pull request #1522