-
Notifications
You must be signed in to change notification settings - Fork 653
Conversation
@saghul @tjfontaine Reopening a new PR because GitHub wouldn't let me reopen #1521. The code has been updated to follow @saghul's design closely. There are still a few of things that are unclear or missing:
Currently, all tests pass on all supported platforms. I've also done a lot of tests with directories containing more than 1 million entries, and the memory footprint stays constant and low. Hopefully this is a step in the right direction! Thank you, |
* | ||
* struct dirent { | ||
* char d_name[ NAME_MAX + 1 ]; | ||
* other stuff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other way around, I believe. d_name
must be the last field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@splinterofchaos Indeed, thank you for catching this!
b78df8d
to
d259c31
Compare
Tested on Linux, MacOS X, SmartOS and Windows. Fixes joyent#1430.
d259c31
to
e967424
Compare
Sorry, this fell through the cracks, can you please reopen it at libuv/libuv? Thanks! |
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574. This commit is just the start of getting them to work in libuv/libuv. Failing tests will be fixed asap. Fixes libuv#170.
This is the same changes as joyent/libuv#1574 but reworked for libuv/libuv. This commit also updates `uv__fs_readdir` to use `readdir` instead of the deprecated `readdir_r`. Fixes libuv#170.
This is the same changes as joyent/libuv#1574 but reworked for libuv/libuv. This commit also updates `uv__fs_readdir` to use `readdir` instead of the deprecated `readdir_r`. Fixes libuv#170.
Tested on Linux, MacOS X, SmartOS and Windows.
Fixes #1430.