Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint, plugins and configure new rules #19

Merged
merged 6 commits into from
Dec 28, 2022
Merged

Update ESLint, plugins and configure new rules #19

merged 6 commits into from
Dec 28, 2022

Conversation

diogoazevedos
Copy link
Member

@diogoazevedos diogoazevedos commented Dec 28, 2022 •
edited
Loading

  • Remove deprecated core and plugin rules.
  • Add node.js 18.x to CI matrix.
  • Improve tests to detect removed and deprecated rules.

@diogoazevedos diogoazevedos self-assigned this Dec 28, 2022
@diogoazevedos diogoazevedos marked this pull request as ready for review December 28, 2022 14:57
hugumberto
hugumberto approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@hugumberto hugumberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@diogoazevedos diogoazevedos merged commit aea349b into joyn:master Dec 28, 2022
@diogoazevedos diogoazevedos deleted the feat/upgrade-dependencies branch December 28, 2022 15:01
@diogoazevedos diogoazevedos added enhancement New feature or request upgrade Pull requests that update a dependency file labels Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugumberto hugumberto hugumberto approved these changes

Assignees

@diogoazevedos diogoazevedos

Labels
enhancement New feature or request upgrade Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogoazevedos @hugumberto