Support for calling run function in node.js

[4ver]

No description provided.

[hassankhan]

Not quite sure if we should have to make changes because jsDom doesn't support what we need. There is an open issue on their repo, maybe we should pester them to get it working.

The only reason I'm hesitant to get rid of TreeWalker is performance-related, last I checked it beats other methods of traversal, but I did check a long time ago 😄

[4ver]

The fact that the issue has been open for three years isn't all that encouraging. I don't think the change would affect the performance majorly (could even be faster).

[4ver]

I could make it so my tree traversal function is used instead of TreeWalker when it's not available. It would only be an extra 20 or so lines.

[hassankhan]

Yep, I'd be happy with that, the other thing, I'd rather it didn't have to pass a window object in run(), am I missing something?

[4ver]

Great! The window object is needed to call functions like document.getElementById, document.createElement and createTreeWalker if it was available. You only need to pass it when it's not available (in node).

[4ver]

This is ready to be merged now.

[adam-lynch]

Should the node-only tests be gone now? Maybe we could just have all the tests in the tests directory, with browser.html and rename browser.js to node.js?

[adam-lynch]

Also, you probably need to update CONTRIBUTING.md

[4ver]

Moved the tests around there. Not sure where to put the actual tests. Wouldn't be all that nice having a tests/tests directory 😛. Can leave the html file and runner.js in the browser directory though.

[adam-lynch]

Test structure looks good to me

[hassankhan]

Thanks @4ver!