Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JozuFile and adjust to the new format #12

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

gorkem
Copy link
Contributor

@gorkem gorkem commented Feb 12, 2024

New format introduces code, dataset and model as distinct media types for layers.

  • Update ModelLayer struct and NewLayer function to be able to pass mediaTypes to layers
  • Update Apply function in ModelLayer
  • Update RunBuild function in build.go to add layers according to the loaded jozufile.
  • Update getManifestInfoLine function in models.go to adjust to jozufile format
  • Update consts.go with new media types
  • Update saveContentLayer function in local.go to read the mediatype from layer.

@gorkem gorkem requested a review from amisevsk February 12, 2024 21:51
Update ModelLayer struct and NewLayer function to
be able to pass mediaTypes to layers
Update Apply function in ModelLayer
Update RunBuild function in build.go to add layers
according to the loaded jozufile.

Update getManifestInfoLine function in models.go to
adjust to jozufile format

Update consts.go with new media types

Update saveContentLayer function in local.go to
read the mediatype from layer.
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you include an updated example file?

pkg/artifact/jozu_file.go Show resolved Hide resolved
@gorkem gorkem merged commit 8c5327c into main Feb 13, 2024
1 check passed
@gorkem gorkem deleted the build-update-jozu branch February 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants