Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jozu AI/ML Packaging Manifest Format Reference #9

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Conversation

gorkem
Copy link
Contributor

@gorkem gorkem commented Feb 11, 2024

This document is a starting point for a user reference but at this stage more of a specification that is open for discussion.

Fixes [sc-123]

Copy link

This pull request has been linked to Shortcut Story #123: Jozufile syntax glossary.

@gorkem gorkem marked this pull request as draft February 12, 2024 14:16
Copy link
Contributor

@bmicklea bmicklea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, there are a few things that don't quite make sense to me but I left specific comments on those.

pkg/cmd/build/jozu-file.md Outdated Show resolved Hide resolved
pkg/cmd/build/jozu-file.md Outdated Show resolved Hide resolved
pkg/cmd/build/jozu-file.md Outdated Show resolved Hide resolved
pkg/cmd/build/jozu-file.md Show resolved Hide resolved
pkg/cmd/build/jozu-file.md Show resolved Hide resolved
@bmicklea
Copy link
Contributor

How do we handle credentials for models, data, etc...?

pkg/cmd/build/jozu-file.md Outdated Show resolved Hide resolved
pkg/cmd/build/jozu-file.md Show resolved Hide resolved
pkg/cmd/build/jozu-file.md Outdated Show resolved Hide resolved
@gorkem gorkem marked this pull request as ready for review February 13, 2024 15:51
gorkem and others added 6 commits February 13, 2024 11:01
Remove artifact section and clarify how
path values are calculated
Co-authored-by: Angel Misevski <amisevsk@gmail.com>
Co-authored-by: Angel Misevski <amisevsk@gmail.com>
Copy link
Contributor

@bmicklea bmicklea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - we'll need to iterate but this is a reasonably slim and smart starting point.

@gorkem gorkem merged commit 7e00899 into main Feb 16, 2024
1 check passed
@gorkem gorkem deleted the jozu-file-doc branch February 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants