Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few trivial functions #176

Merged
merged 3 commits into from
May 26, 2024
Merged

Add a few trivial functions #176

merged 3 commits into from
May 26, 2024

Conversation

jp7677
Copy link
Owner

@jp7677 jp7677 commented May 26, 2024

I looked again at the War Thunder issue. Add the three functions here didn't changed anything wrt the DLSS crashes, but since they are fairly straight forward, we might just keep them.

@jp7677 jp7677 requested a review from Saancreed May 26, 2024 08:10
@@ -206,6 +206,11 @@ namespace dxvk {
return m_dxgiDesc.DedicatedVideoMemory / 1024;
}

uint32_t NvapiAdapter::GetVirtualVRamSize() const {
// Report VRAM size from DXVK to honor memory overrides
return (m_dxgiDesc.DedicatedVideoMemory + m_dxgiDesc.DedicatedSystemMemory) / 1024;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reality DedicatedSystemMemory will always be zero, see https://github.com/doitsujin/dxvk/blob/master/src/dxgi/dxgi_adapter.cpp#L371

@jp7677 jp7677 merged commit b7e018f into master May 26, 2024
2 checks passed
@jp7677 jp7677 deleted the aces-functions branch May 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants