Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

The verify argument is deprecated in jwt.decode #341

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 12, 2017

This uses the "verify_signature" option instead.

This uses the "verify_signature" option instead.
@angvp
Copy link
Contributor

angvp commented Jun 12, 2017

This PR is breaking the tests, would you mind to fix it?

@blueyed
Copy link
Contributor Author

blueyed commented Jun 12, 2017

Sure.

But it looks like verify is not actually deprecated for PyJWT.decode, but only PyJWS.decode.
Let's wait on the outcome of jpadilla/pyjwt#271.

@jpadilla
Copy link
Owner

@blueyed can you still check this out, if not I can take over. Looking to release a new version today.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 22, 2017

With jpadilla/pyjwt#271 there are no more deprecation warning here, so this can be closed.

@blueyed blueyed closed this Jun 22, 2017
@blueyed blueyed deleted the fix-DeprecationWarning branch June 22, 2017 18:45
@jpadilla
Copy link
Owner

Ace, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants