Add JWK support for HMAC and RSA keys #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-adams
force-pushed
the
add-jwk-for-hmac-rsa
branch
from
de2d6af to
7e1193e
Compare
mark-adams
force-pushed
the
add-jwk-for-hmac-rsa
branch
2 times, most recently
from
3466f90 to
41c24b2
Compare
|
@mark-adams let me know if there's anything I can help with. |
mark-adams
force-pushed
the
add-jwk-for-hmac-rsa
branch
6 times, most recently
from
22b5e39 to
12b24be
Compare
|
@jpadilla Mind taking a look at this? |
mark-adams
force-pushed
the
add-jwk-for-hmac-rsa
branch
2 times, most recently
from
dad9ba4 to
bfa24f3
Compare
| 'kty': 'RSA', | ||
| 'use': 'sig', | ||
| 'key_ops': ['verify'], | ||
| 'n': force_unicode(to_base64url_uint(numbers.n)), |
There was a problem hiding this comment.
I cannot find specific documentation on encoding RSA keys, but the examples I have seen include modulus (n) and public exponent (e) values in both the private and public keys.
There was a problem hiding this comment.
You are correct. That was an oversight on my part. I missed the text that says:
In addition to the members used to represent RSA public keys, the
following members are used to represent RSA private keys.
|
This looks good to go once the comments are addressed. Thanks, @mark-adams! |
- JWKs for RSA and HMAC can be encoded / decoded using the .to_jwk() and .from_jwk() methods on their respective jwt.algorithms instances - Replaced tests.utils ensure_unicode and ensure_bytes with jwt.utils versions
mark-adams
force-pushed
the
add-jwk-for-hmac-rsa
branch
from
1786120 to
42b0114
Compare
|
@jpadilla Does this look good to you? |
jpadilla
approved these changes
Sep 28, 2016
|
@mark-adams yup, all yours! |
This was referenced Jun 22, 2017
This was referenced Jul 1, 2017
This was referenced Jul 18, 2017
This was referenced Sep 5, 2017
This was referenced Nov 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for JWK serialization to HMAC and RSA keys.
Looking something like this:
and also