Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly warn against computing algorithms from the token’s alg #647

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Clearly warn against computing algorithms from the token’s alg #647

merged 1 commit into from
Apr 28, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Apr 16, 2021 •
edited
Loading

This seems to be a common temptation (python-social-auth/social-core#514, twilio/twilio-python#560 (comment)), so we should clarify why it’s a bad idea.

@andersk
Clearly warn against computing algorithms from the token’s alg
1705726 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@jpadilla jpadilla added the docs label Apr 16, 2021
jpadilla
jpadilla approved these changes Apr 16, 2021
View reviewed changes
Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, good find! 👍

@jpadilla jpadilla merged commit 7f6a236 into jpadilla:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpadilla jpadilla jpadilla approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersk @jpadilla