[FIX] remove references to removed type 'MutableEigenMatrixXdPtr' #6
Conversation
|
I'm testing IsobaricWorkflow with some example files from a KNIME tutorial that Timo found (https://abibuilder.cs.uni-tuebingen.de/archive/openms/Tutorials/Example_Data/IsobaricTMT/). It doesn't seem to work. I get the message "Found MS3 spectra. Assuming TMT SPS-MS3 workflow.", but after that nothing happens. Not sure if my changes in this PR caused the problem or if it was already there. |
|
Probably was there. How are you generating the IDs? |
|
Unless the changes generate all zero intensities after correction (i.e. due to missing copies and in-place editing of the correction matrix). But I guess you would get different behaviour. |
| // @jpfeuffer why shared_ptr needed here? | ||
| static void solveNNLS_(std::shared_ptr<Eigen::MatrixXd> & correction_matrix, std::vector<double> & b, std::vector<double> & x); | ||
| static void solveNNLS_(std::shared_ptr<const Eigen::MatrixXd> & correction_matrix, std::vector<double> & b, std::vector<double> & x); | ||
| // @jpfeuffer why shared_ptr needed here? |
There was a problem hiding this comment.
Because that is what MutableEigenMatrixXdPtr was typedef'd to and what you got out of conversion.
Don't ask me why.
That was part of the KNIME workflow (which Matteo ran for me). Uses MS-GF+ followed by Percolator. |
|
Hmm can you upload one of those? |
|
Ok, so this dataset has no precursor windows annotated, which is weird I would say. |
|
@hendrikweisser Should be fixed in the origin PR now. |
Fix compiler errors - untested