Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change marketplace_fee stake_key hash with the one we currently use #3

Merged
merged 1 commit into from
Jul 14, 2023
Merged

change marketplace_fee stake_key hash with the one we currently use #3

merged 1 commit into from
Jul 14, 2023

Conversation

joacohoyos
Copy link
Contributor

@rvcas
Copy link
Contributor

rvcas commented Jul 14, 2023

I think we also need to update the e2e tests. CI is failing cause the address doesn't match which is comforting cause it means the check works lol.

rvcas
rvcas suggested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@rvcas rvcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should probably re-run aiken build and then commit the new plutus.json. If you don't have aiken installed I can handle that.

@rvcas rvcas merged commit 8eeec04 into main Jul 14, 2023
@rvcas rvcas deleted the clark/change-fee-skh branch July 14, 2023 15:05
@joacohoyos joacohoyos mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvcas rvcas rvcas approved these changes

@MicroProofs MicroProofs Awaiting requested review from MicroProofs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joacohoyos @rvcas