Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide local files button in VIEW mode #1628

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Feb 29, 2024

using the cli with -M VIEW shows a button stating that the user could continue with local files.

This is because the report viewer returns the index.html when the requested file was not found. There was a check for the filetype but it did not account for multiple variants of the text/html type.

This PR accounts for multiple variants of this like text/html; charset=utf-8

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Kr0nox Kr0nox added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Feb 29, 2024
@sebinside sebinside merged commit eb71247 into develop Mar 5, 2024
16 checks passed
@sebinside sebinside deleted the bug-fix/local-files-button branch March 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants