Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unhiding through searchbar #1632

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Mar 5, 2024

Currently it was not possible to unhide names that contained spaces through the search bar.

This PR fixes it by also splitting names at spaces and checking if every part of the string is contained in the search string parts.

Fixes #1629

@Kr0nox Kr0nox added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Mar 5, 2024
@Kr0nox Kr0nox requested a review from sebinside March 5, 2024 16:11
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebinside sebinside merged commit f663f78 into develop Mar 6, 2024
16 checks passed
@sebinside sebinside deleted the report-viewer/fix-search-space branch March 6, 2024 11:53
@Kr0nox Kr0nox mentioned this pull request Mar 6, 2024
Copy link

@SaiPreethamD20 SaiPreethamD20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants