Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added idle bars #1680

Merged
merged 9 commits into from
May 3, 2024
Merged

Added idle bars #1680

merged 9 commits into from
May 3, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Apr 2, 2024

Adds Idle Bars, that behave like progress bars, but do not show a linear progress and instead only indicate that something is happening. They can be used, when the amount of operations is unknown.

@TwoOfTwelve

This comment was marked as outdated.

@TwoOfTwelve TwoOfTwelve marked this pull request as draft April 2, 2024 12:02
@TwoOfTwelve TwoOfTwelve requested a review from tsaglam April 2, 2024 12:03
@Kr0nox

This comment was marked as outdated.

@TwoOfTwelve

This comment was marked as outdated.

@Kr0nox

This comment was marked as outdated.

@TwoOfTwelve

This comment was marked as outdated.

@Kr0nox

This comment was marked as outdated.

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the main method under macOS, both in IDE and in the terminal. Looks good, no issues. Adapts to terminal window size.

# Conflicts:
#	cli/src/main/java/de/jplag/cli/CLI.java
#	core/src/main/java/de/jplag/logging/ProgressBarType.java
@TwoOfTwelve TwoOfTwelve marked this pull request as ready for review April 17, 2024 08:58
@Kr0nox
Copy link
Member

Kr0nox commented Apr 19, 2024

@TwoOfTwelve I dont get a progess bar during clustering is that on purpose?

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Apr 25, 2024
@tsaglam tsaglam added this to the 5.1.0 milestone Apr 25, 2024
Copy link

sonarcloud bot commented May 2, 2024

@tsaglam tsaglam merged commit 649a595 into develop May 3, 2024
35 checks passed
@tsaglam tsaglam deleted the feature/idleBars branch May 3, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants