Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jar Upload #1697

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix Jar Upload #1697

merged 1 commit into from
Apr 10, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Apr 9, 2024

fixes #1597
Jar is now correctly attached to the workflow run

@Kr0nox Kr0nox added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change github_actions Pull requests that update GitHub Actions code labels Apr 9, 2024
@Kr0nox Kr0nox requested a review from tsaglam April 9, 2024 19:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tsaglam tsaglam changed the title Fix Jat Upload Fix Jar Upload Apr 10, 2024
tsaglam
tsaglam approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tsaglam tsaglam merged commit 6cbdfa6 into develop Apr 10, 2024
5 checks passed
@tsaglam tsaglam deleted the bugfix/build-action branch April 10, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug github_actions Pull requests that update GitHub Actions code minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @tsaglam