Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better warning for missing files #1747

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented May 3, 2024

Previously when submission files were missing the report viewer would display an error message stating: Could not load comparison: Cannot read properties of undefined.
Now it tells the user that the report viewer expected a file that it did not find and states the name of the file:
Could not load comparison: The report viewer expected to find the file Cyan Lynx\Sociologia.java in the submissions, but did not find it.

@Kr0nox Kr0nox added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels May 3, 2024
@Kr0nox Kr0nox requested a review from a team May 3, 2024 07:40
Copy link

sonarcloud bot commented May 3, 2024

@tsaglam tsaglam merged commit e91e4bc into develop May 14, 2024
40 checks passed
@tsaglam tsaglam deleted the report-viewer/better-warning branch May 14, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants