Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command line option for log-level #1751

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Conversation

TwoOfTwelve
Copy link
Contributor

Added a cli option to set the log-level

@Kr0nox
Copy link
Member

Kr0nox commented May 4, 2024

Do we want the progress bars on level that shows less than info? (WARN, ERROR) Users that select these levels probably actually only want warnings and errors

Do we want to keep the progress bars on DEBUG and TRACE? They are barely visible anyway and due to #1719 the additional messages are cut off sometimes

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels May 6, 2024
# Conflicts:
#	cli/src/main/java/de/jplag/cli/CLI.java
Copy link

sonarcloud bot commented May 16, 2024

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing and a sonar issue.

cli/src/main/java/de/jplag/cli/logger/JPlagLoggerBase.java Outdated Show resolved Hide resolved
@tsaglam tsaglam added this to the 6.0.0 milestone May 27, 2024
Copy link
Member

@Kr0nox Kr0nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readding my comment from above as requested changes, to not forget it before merging:

Do we want the progress bars on level that shows less than info? (WARN, ERROR) Users that select these levels probably actually only want warnings and errors

Do we want to keep the progress bars on DEBUG and TRACE? They are barely visible anyway and due to #1719 the additional messages are cut off sometimes

In the meeting we decided we dont want the bar on any level other than info

@tsaglam
Copy link
Member

tsaglam commented Jun 19, 2024

@TwoOfTwelve one conflict has to be solved before I can merge.

# Conflicts:
#	cli/src/main/java/de/jplag/cli/options/CliOptions.java
…re/cliLogLevel

# Conflicts:
#	cli/src/main/java/de/jplag/cli/logger/CliProgressBarProvider.java
#	cli/src/main/java/de/jplag/cli/logger/CollectedLogger.java
#	cli/src/main/java/de/jplag/cli/logger/JPlagLoggerBase.java
Copy link

sonarcloud bot commented Jun 26, 2024

Copy link

sonarcloud bot commented Jun 26, 2024

@tsaglam tsaglam merged commit 5629efd into develop Jun 27, 2024
54 checks passed
@tsaglam tsaglam deleted the feature/cliLogLevel branch June 27, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants