-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command line option for log-level #1751
Conversation
Do we want the progress bars on level that shows less than info? (WARN, ERROR) Users that select these levels probably actually only want warnings and errors Do we want to keep the progress bars on DEBUG and TRACE? They are barely visible anyway and due to #1719 the additional messages are cut off sometimes |
# Conflicts: # cli/src/main/java/de/jplag/cli/CLI.java
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing and a sonar issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readding my comment from above as requested changes, to not forget it before merging:
Do we want the progress bars on level that shows less than info? (WARN, ERROR) Users that select these levels probably actually only want warnings and errors
Do we want to keep the progress bars on DEBUG and TRACE? They are barely visible anyway and due to #1719 the additional messages are cut off sometimes
In the meeting we decided we dont want the bar on any level other than info
…g levels other than info
@TwoOfTwelve one conflict has to be solved before I can merge. |
# Conflicts: # cli/src/main/java/de/jplag/cli/options/CliOptions.java
…re/cliLogLevel # Conflicts: # cli/src/main/java/de/jplag/cli/logger/CliProgressBarProvider.java # cli/src/main/java/de/jplag/cli/logger/CollectedLogger.java # cli/src/main/java/de/jplag/cli/logger/JPlagLoggerBase.java
Quality Gate passed for 'JPlag Report Viewer'Issues Measures |
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
Added a cli option to set the log-level