Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overscroll when clicking match #1871

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix overscroll when clicking match #1871

merged 2 commits into from
Jul 19, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jul 16, 2024 •
edited
Loading

When clicking on a match, it was possible to overscroll the entire page and thus making important information inaccessible.

This PR solves this by:

  • Scrolling to the line number and not the text line
  • Vertical scrolling is now performed by manually calculating the scroll offset

@Kr0nox Kr0nox added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jul 16, 2024
@Kr0nox Kr0nox requested review from TwoOfTwelve and a team July 16, 2024 08:50
@Kr0nox Kr0nox marked this pull request as draft July 16, 2024 13:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Kr0nox Kr0nox marked this pull request as ready for review July 16, 2024 14:36
tsaglam
tsaglam approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tsaglam tsaglam mentioned this pull request Jul 19, 2024
Merged
@tsaglam tsaglam merged commit 38e72cd into develop Jul 19, 2024
49 checks passed
@tsaglam tsaglam deleted the report-viwer/fix-scroll branch July 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@TwoOfTwelve TwoOfTwelve Awaiting requested review from TwoOfTwelve

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @tsaglam