Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› atom link needs to point to self #122

Merged
merged 1 commit into from
May 25, 2020

Conversation

decebal
Copy link
Contributor

@decebal decebal commented May 21, 2020

βœ… Closes: #113

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.634% when pulling 07b0c0f on decebal:fix/atom-link into abfe55b on jpmonette:master.

@jpmonette jpmonette merged commit 6063e8b into jpmonette:master May 25, 2020
@jpmonette
Copy link
Owner

Thanks @decebal

@decebal decebal deleted the fix/atom-link branch May 26, 2020 10:21
decebal added a commit to decebal/feed that referenced this pull request Jun 5, 2020
βœ… Closes: 113

Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com>
jpmonette added a commit that referenced this pull request Jun 6, 2020
* Sanitizing XML feeds

* Adding missing things from previous commit and also support for image with more data

* Fix RSS ignoring item.id (#105)

* Change id to a guid

This improves the tests. It also replicates #96.

* Fix RSS ignoring item.id

Fixes #96 with the code that KnicKnic suggested

* Bump lodash from 4.17.11 to 4.17.15 (#106)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>

* Create FUNDING.yml

* Bump handlebars from 4.1.2 to 4.5.3 (#110)

Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

* Item category for all feed types (#109)

* Item category for all feed types.

* updated version

* use rimraf instead of rm -rf for dev purposes.

* Bump to 4.1.0

* Bump acorn from 5.7.3 to 5.7.4 (#116)

Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: 🎸 add mandatory rss2 attributes on enclosure (#120)

Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com>

* fix: πŸ› atom link needs to point to self (#122)

βœ… Closes: 113

Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com>

* Update dependencies + Formatting + Add Comments (#123)

* Update dependencies

* Update formating

* Add comments

* Bump to 4.2.0

Co-authored-by: Karl Ravn <karl.ravn@schibsted.com>
Co-authored-by: Joseph Dykstra <josephdykstra@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jean-Philippe Monette <jpmonette@users.noreply.github.com>
Co-authored-by: mattimbrain <matti.kaivanto@m-brain.com>
Co-authored-by: Jean-Philippe Monette <contact@jpmonette.net>
Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atom:link in RSS feed should point to self, not atom
3 participants