Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default RSS docs url + Allow docs override #97

Merged
merged 4 commits into from
Aug 11, 2019
Merged

Change default RSS docs url + Allow docs override #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4935cb4
Change default docs url to RSS2 spec at W3C
awfulwoman Aug 7, 2019
09eca02
Catch all instances of harvard law blog
awfulwoman Aug 7, 2019
4669338
Add ability to override docs option
awfulwoman Aug 7, 2019
9d6eedb
Update snapshot
awfulwoman Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/rss2.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`rss 2.0 should generate a valid feed 1`] = `
<link>http://example.com/</link>
<description>This is my personnal feed!</description>
<lastBuildDate>Sat, 13 Jul 2013 23:00:00 GMT</lastBuildDate>
<docs>http://blogs.law.harvard.edu/tech/rss</docs>
<docs>https://validator.w3.org/feed/docs/rss2.html</docs>
<generator>https://github.com/jpmonette/feed</generator>
<language>en</language>
<image>
Expand Down
12 changes: 6 additions & 6 deletions src/rss2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default (ins: Feed) => {
link: { _text: options.link },
description: { _text: options.description },
lastBuildDate: { _text: options.updated ? options.updated.toUTCString() : new Date().toUTCString() },
docs: { _text: "http://blogs.law.harvard.edu/tech/rss" },
docs: { _text: options.docs ? options.docs : "https://validator.w3.org/feed/docs/rss2.html" },
generator: { _text: options.generator || generator }
}
}
Expand All @@ -33,7 +33,7 @@ export default (ins: Feed) => {

/**
* Channel Image
* http://cyber.law.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt
* https://validator.w3.org/feed/docs/rss2.html#ltimagegtSubelementOfLtchannelgt
*/
if (options.image) {
base.rss.channel.image = {
Expand All @@ -45,15 +45,15 @@ export default (ins: Feed) => {

/**
* Channel Copyright
* http://cyber.law.harvard.edu/rss/rss.html#optionalChannelElements
* https://validator.w3.org/feed/docs/rss2.html#optionalChannelElements
*/
if (options.copyright) {
base.rss.channel.copyright = { _text: options.copyright };
}

/**
* Channel Categories
* http://cyber.law.harvard.edu/rss/rss.html#comments
* https://validator.w3.org/feed/docs/rss2.html#comments
*/
ins.categories.map(category => {
if (!base.rss.channel.category) {
Expand Down Expand Up @@ -99,7 +99,7 @@ export default (ins: Feed) => {

/**
* Channel Categories
* http://cyber.law.harvard.edu/rss/rss.html#hrelementsOfLtitemgt
* https://validator.w3.org/feed/docs/rss2.html#hrelementsOfLtitemgt
*/
base.rss.channel.item = [];

Expand Down Expand Up @@ -134,7 +134,7 @@ export default (ins: Feed) => {
}
/**
* Item Author
* http://cyber.law.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt
* https://validator.w3.org/feed/docs/rss2.html#ltauthorgtSubelementOfLtitemgt
*/
if (Array.isArray(entry.author)) {
item.author = [];
Expand Down
1 change: 1 addition & 0 deletions src/typings/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export interface FeedOptions {
feed?: string;
feedLinks?: any;
hub?: string;
docs?: string;

author?: Author;
link?: string;
Expand Down