Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Support #20

Closed
SethDusek opened this issue Jan 14, 2021 · 9 comments
Closed

Proxy Support #20

SethDusek opened this issue Jan 14, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@SethDusek
Copy link

Hello, I have tried using psst but I am unable to connect to Spotify. I believe this is because Spotify now has even stricter region requirements. I tried using proxychains4, but it doesn't seem to work properly with this application. The main Spotify client has an option to select a SOCKS5/SOCKS4/HTTP proxy. Are there any plans to add this to psst as well?

@jpochyla jpochyla added the enhancement New feature or request label Jan 14, 2021
@jpochyla
Copy link
Owner

We could do this, yeah! As we're also using a TCP session to talk to Spotify, SOCKS would be needed, right?

@SethDusek
Copy link
Author

Yea I think so. I personally use my VPS + ssh SOCKS5 to get around the region restrictions

@jpochyla
Copy link
Owner

I've looked into this a bit and while HTTP proxy would be possible to use as well, SOCKS5 would be easiest to implement. I'll get to it through the next week.

@jpochyla
Copy link
Owner

jpochyla commented Feb 1, 2021

I have a SOCKS5 support implemented for the TCP session and the CDN connections, but the Spotify WebAPI would need a small PR for aspotify, so it will take a couple more days, but it's close.

@jpochyla
Copy link
Owner

jpochyla commented Mar 10, 2021

Hah, sorry, that took longer then expected :) I've completely removed aspotify and we do our own thing now. If you're still interested and feel adventurous, try latest master. I haven't tested it yet, but setting SOCKS_PROXY env var to smth. like socks5://john:smith@socks.google.com should work. In the future, we could add it to the Preferences dialog.

@jpochyla
Copy link
Owner

Closing, feel free to open in case of any issues!

@aslafy-z
Copy link

This issue should be reopened since support for HTTP proxy is not present. I had a look to ureq, it seems that it won't be implemented from now on, see algesten/ureq#62. What were the reasons behind the choice of ureq? It looks like https://github.com/seanmonstar/reqwest for example has many more features (including http_proxy support) and is better supported.

@jpochyla
Copy link
Owner

jpochyla commented Aug 18, 2021

reqwest is an async client, we need only sync interface. And if I'm not mistaken, ureq does support HTTP proxies. The reason only SOCKS is supported in Psst is that we're connecting to a TCP session, and tunelling that through HTTP CONNECT is slightly more work. PRs welcome!

@Metacinnabar
Copy link

HTTP proxy support would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants