Homepage revamp #520
Homepage revamp #520
Conversation
|
The only other project that does retrieve these made for you sections is Spotube. The hidden Spotify endpoints they discovered are here. It might be helpful in your redesign. We should be adding these to home regardless but their API is a little tricky for these I think - they need to be destructured in a particular way. |
|
That has made me very excited, I also spotted a "what are your friends listening to" section! I'll happily work on working out the apis. Do you think the current drafts layout is effective, we could possibly keep the "your top artists and tracks" section at the bottom as I personally really like being able to use it. |
|
Having a look at this now, and will give some feedback! |
|
Overall I like it! Some thoughts:
|
…artist same height/width
|
I made a small commit that does the sanitization of tags and unifies the playlist and artist thumbnail heights, I made them a bit smaller to be more cohesive with the UI. I think we should probably sanitize the HTML at some earlier step getting the playlist and the widget should be drawing from the existing way we pull playlist information - I feel there is quite a bit of duplicate code as it stands. |
|
The changes you made look lovely! Thank you!!! I agree I will try and reduce the code once the functionality is there :) |
|
Oh, I also wanted to mention, because I saw it in some comment in the code, that all users should be able to scroll horizontally by holding Shift and scrolling. At least that's how it works on Mac and Windows. So if you have your cursor over the horizontal scroll section, you should be able to press Shift and scroll and it'll scroll through. |
|
Ah, perfect. Thank you; that makes it a lot easier for me! I've now added almost all of the home sections to the playlists. Should I use the UI for the search section to have horizontal sections? |
|
I think that should probably be a separate PR so we can just change one view at a time. I think there's some expectation with a search to see a list of items. |
|
Ok perfect thanks! |
…and episodes for you! Also remove changes to uneeded places
|
I made just a few cleanup changes.
|
|
If those changes look good to you we can merge! |
|
Thank you for these changes, i think that we need to give a little extra height to allow some extra space at the bottom, as that gets cut off by the scroll bar! |
|
Cool, I changed it to be 8.0. If you are happy with it, go ahead and merge! Thank you. By the way, I enjoyed working on this! |
|
Also, I was wondering if we should redo the saved podcasts section to include recommended episodes and shows. It should be pretty easy to do. |
|
@jacksongoode Weirdly, I think the jump-back-in section has gone off Spotify now... How weird! I'll check back in the morning, but if it still isn't there (I mean on the Spotify website), I'll submit a quick patch. How annoying :/ |
|
Wait it is still a thing! Why isn't it loading the data properly anymore I haven't changed anything!? Could you check this on your machine @jacksongoode |
|
Oh no I still see it on my end, can you debug the call? |
|
Oh its just my laptop giving up! I cleared the cache and its all fine now :) sorry for the alarm bells! |
|
What cache did you clear? I'm actually noticing the same issue @SO9010 |
|
@jacksongoode I deleted the whole psst folder for all the cache and then restarted my laptop, but maybe if it's not so stable we should remove it from the home page? |
|
So very weird that it only just became a problem and only for that section. I've just checked my machines again and it is fine on both windows and Linux ATM |
|
Hmm I did remove the cache but still get the error... |
|
@jacksongoode is this still an error? Its still ok on my ends! |
|
I'm also getting an error, it's looking for missing fields in the json file apparently. Screenshot:
|
|
This is so odd that this has only just turned up as an issue! I submitted a PR to fix the track adding. But maybe we should revert the merge to main? I can start reworking it. |
|
I'm thinking this has got to do with the API call request to get the users timezone and location. We should get the user to set this up at the start. Maybe there's a crate which can be used. |
|
@arch-btw are you using a VPN I'm thinking that could be the issue as it currently uses the computers IP address |
|
Okay, I don't think that the issue is coming from the IP address, as I just tried a VPN, and also, your uniquely yours wouldn't show up if it were. I also just had an idea: We could have it so that instead of showing the error, it only loads the items it can get, so we just display an empty widget. @jacksongoode, what do you think? |
|
@arch-btw don't worry, just out of curiosity how does the home layout look for you now after the most recent merge |
|
Oops, I didn't see your message! Here is what it currently looks like.
|
|
@SO9010 We should probably be also have the title appear contingent on the panel's network request actually loading. |
This aims to sort #519 ! Please message there if there's anything you would want to see implemented! here is the current rough rough rough state of this PR!
Screencast.from.2024-09-05.21-00-56.mp4