-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buttons and functionality #511
base: main
Are you sure you want to change the base?
Conversation
psst-gui/src/widget/icons.rs
Outdated
@@ -94,6 +94,13 @@ pub static PLAY_LOOP_ALL: SvgIcon = SvgIcon { | |||
op: PaintOp::Fill, | |||
}; | |||
|
|||
// Font awesome - reload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get all icons from SF Pro Regular https://developer.apple.com/sf-symbols/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, I can go through and replace all of the icons with those ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, I can go through and replace all of the icons with those ones?
Hold on, I am unable to access any of those symbols as I don't have an Apple machine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/brendanballon/sfsymbols-svg/tree/master/symbols
I think the SVG's can be found at other places too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will rewrite the way that the program processes the SVG files so then we are able to place all of the files into a directory rather than having to extract the curve. It would save a lot of time in the end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think part of the reason was that the SVG paths alone took up less size and might be quicker to load?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, do you know if there's an efficient way to move the "view" of the path as for example with the gear icon it doesn't start at the top left meaning that it's strongly displaced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacksongoode how does this look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These icons still look quite big from a UI consistency pov. I also think they need a little padding so they don't hit the right side too hard.
Adds two buttons to help usability.