-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New authentication flow to resolve #515 #517
Conversation
@Insprill Since this is a big one and high prio, would you have time to look over this and review? |
@SO9010 Just to check with another person, does this method work for you from this branch? |
By the way, now everyone required is back from holiday we'll hopefully be merging our librespot PR for this. It's currently going through some review. The intention is to publish a librespot-oauth create but when that'll see an actual release, I can't say. I appreciate you might prefer to control your own copy of that code, this is more just a note that the original version is seeing some updates (error handling mostly) so there may be value in waiting for those. |
I'll try it out tomorrow! |
@kingosticks Thanks for the update, I've been following changes to that PR. I think it does just make sense to roll our own implementation here. If you notice anything odd here feel free to point it out, it was based around your work so thank you! |
@jacksongoode This works perfectly for me!!! |
d288f39
to
aeb0add
Compare
This resolves the issue with a new OAuth method largely referencing the work done in librespot librespot-org/librespot#1309. After this username/pass is completely depreciated. I may not have removed all unused references so I'd be happy for reviews and edits.