Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Node 14 #800

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix tests on Node 14 #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae91dd
Fix tests on Node 14
RyanZim May 14, 2020
430d793
Add Node 14 to CI
RyanZim May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ node_js:
- 11
- 12
- 13
- 14
env: TEST_SUITE=unit
matrix:
exclude:
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ environment:
# node.js
- nodejs_version: "10"
- nodejs_version: "12"

- nodejs_version: "14"
# Install scripts. (runs after repo cloning)
install:
# Get the latest stable version of Node.js or io.js
Expand Down
4 changes: 2 additions & 2 deletions lib/ensure/__tests__/create.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('fs-extra', () => {
it('should give clear error if node in directory tree is a file', done => {
const existingFile = path.join(TEST_DIR, Math.random() + 'ts-e', Math.random() + '.txt')
fse.mkdirsSync(path.dirname(existingFile))
fs.writeFileSync(existingFile)
fs.writeFileSync(existingFile, '')

const file = path.join(existingFile, Math.random() + '.txt')
fse.createFile(file, err => {
Expand Down Expand Up @@ -79,7 +79,7 @@ describe('fs-extra', () => {
it('should give clear error if node in directory tree is a file', () => {
const existingFile = path.join(TEST_DIR, Math.random() + 'ts-e', Math.random() + '.txt')
fse.mkdirsSync(path.dirname(existingFile))
fs.writeFileSync(existingFile)
fs.writeFileSync(existingFile, '')

const file = path.join(existingFile, Math.random() + '.txt')
try {
Expand Down
2 changes: 1 addition & 1 deletion lib/remove/__tests__/remove.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function buildFixtureDir () {

const subDir = path.join(TEST_DIR, Math.random() + '')
fs.mkdirSync(subDir)
fs.writeFileSync(path.join(subDir, Math.random() + ''))
fs.writeFileSync(path.join(subDir, Math.random() + ''), buf)
return baseDir
}

Expand Down