-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add package main field for TypeScript support #981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also: #980
Tested locally, and resolves the issue with TypeScript.
It doesn't resolve the issue with |
It doesn't have to, right? Importing from fs-extra will get the esm version if I'm not mistaken. |
If I understand @RyanZim's intention correctly, the separate We could just add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more conservative solution is to omit the module
field for now, because the author does not intend to export the ESM module at fs-extra
.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested and still resolves the issue when using import fs from "fs-extra";
in TypeScript.
I removed the
I think that's fine; @caugner is correct; we don't want to add |
Published in v11.1.0 🎉 |
Fixes #979