Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase Request.Error members to conform to Swift 3 API Design Guidelines #272

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

norio-nomura
Copy link
Collaborator

@available will be added by separate commit.

…elines

`@available` will be added by separate commit.
Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpsim jpsim merged commit 9ddabb6 into jp-swift-3-api-guidelines Oct 18, 2016
@jpsim jpsim deleted the nn-lowercase-request-error branch October 18, 2016 00:13
jpsim added a commit that referenced this pull request Oct 18, 2016
* label argument in CXCursor.swiftDeclaration() method

* rename CodeCompletionItem.parseResponse(_:) for Swift 3

* update File.swift for Swift 3 API Design Guidelines

* update Language enum members to be lowercase for Swift 3 API Design Guidelines

* Rename DynamicLinkLibrary.loadSymbol(_:) to load(symbol:)

for Swift 3 API Design Guidelines

* update library_wrapper.swift for Swift 3 API Design Guidelines

* update ObjCDeclarationKind members to Swift 3 API Design Guidelines

* change ObjCDeclarationKind.fromClang(_:) to an initializer

* update OffsetMap for Swift 3 API Design Guidelines

* refactor Request.swift for Swift 3 API Design Guidelines

* update SourceDeclaration.swift for Swift 3 API Design Guidelines

* update SourceDeclaration.swift for Swift 3 API Design Guidelines

* update StatementKind, SwiftDeclarationKind and SyntaxKind enums

to have lowercase members to comply with Swift 3 API Design Guidelines

* refactor String+SourceKitten.swift for Swift 3 API Design Guidelines

* refactor SwiftDocKey for Swift 3 API Design Guidelines

* refactor SyntaxMap for Swift 3 API Design Guidelines

* update Xcode.swift for Swift 3 API Design Guidelines

* update sourcekitten target for Swift 3 API Design Guidelines

* refactor tests for Swift 3 API Design Guidelines

* amend Swift 3 changelog entry to note API changes

* lowercase Request members to conform to Swift 3 API Design Guidelines

* lowercase Request.Error members to conform to Swift 3 API Design Guidelines (#272)

`@available` will be added by separate commit.
jpsim added a commit that referenced this pull request Oct 18, 2016
* label argument in CXCursor.swiftDeclaration() method

* rename CodeCompletionItem.parseResponse(_:) for Swift 3

* update File.swift for Swift 3 API Design Guidelines

* update Language enum members to be lowercase for Swift 3 API Design Guidelines

* Rename DynamicLinkLibrary.loadSymbol(_:) to load(symbol:)

for Swift 3 API Design Guidelines

* update library_wrapper.swift for Swift 3 API Design Guidelines

* update ObjCDeclarationKind members to Swift 3 API Design Guidelines

* change ObjCDeclarationKind.fromClang(_:) to an initializer

* update OffsetMap for Swift 3 API Design Guidelines

* refactor Request.swift for Swift 3 API Design Guidelines

* update SourceDeclaration.swift for Swift 3 API Design Guidelines

* update SourceDeclaration.swift for Swift 3 API Design Guidelines

* update StatementKind, SwiftDeclarationKind and SyntaxKind enums

to have lowercase members to comply with Swift 3 API Design Guidelines

* refactor String+SourceKitten.swift for Swift 3 API Design Guidelines

* refactor SwiftDocKey for Swift 3 API Design Guidelines

* refactor SyntaxMap for Swift 3 API Design Guidelines

* update Xcode.swift for Swift 3 API Design Guidelines

* update sourcekitten target for Swift 3 API Design Guidelines

* refactor tests for Swift 3 API Design Guidelines

* amend Swift 3 changelog entry to note API changes

* lowercase Request members to conform to Swift 3 API Design Guidelines

* Add `@available` to swift 3 api guidelines changes

* Add `@available` to `Request.Error`

* lowercase Request.Error members to conform to Swift 3 API Design Guidelines (#272)

`@available` will be added by separate commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants