Fix generic Swift declaration generation from ObjC #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by a patient jazzy user in realm/jazzy#910. When SourceKit produces the full_as_xml as part of a cursorinfo request for a decl imported from ObjC, it forgets to XML-escape the ‘Declaration’. SourceKitten had a fix for ‘&’ but not ‘<’ ‘>’ (generics) - causes truncation of the Swift decl.
This PR changes SourceKitten to always use the annotated_declaration_xml instead of trying to work around the Swift bug -- this XML is generated using different code that has always been escaped properly. For ObjC, the contents of the two declarations are identical.
Testcase change show Realm ObjC was suffering from this -- various generic declarations missing pieces in Swift.