Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcekitten completion results formatting options #712

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

PaulTaykalo
Copy link
Collaborator

@PaulTaykalo PaulTaykalo commented Oct 5, 2021

Since JSON-formatting of code completion results can take a lot of time in some cases, additional format options can be passed to the sourcekitten.

Two additional options added:

  • prettified - whether JSON results should be user-friendly prettified
  • sorted-keys - whether the keys in JSON should be sorted keys

This fixes #710

@PaulTaykalo PaulTaykalo self-assigned this Oct 5, 2021
@PaulTaykalo PaulTaykalo requested a review from jpsim October 5, 2021 18:57
@PaulTaykalo
Copy link
Collaborator Author

PaulTaykalo commented Oct 5, 2021

This is open question whether to make these options available at all, or what options should be by default. If you have some other thoughts on that I would gladly rewrite this PR :) or even close it:)

Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jpsim jpsim merged commit 373d9d1 into master Oct 5, 2021
@jpsim jpsim deleted the improvement/format-output branch October 5, 2021 20:46
@jpsim
Copy link
Owner

jpsim commented Oct 5, 2021

changelog entry: febae1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to turn off JSON pretty printing and sorting of keys for better performance
2 participants