Merge pull request #52 from akszydelko/master

Fix #51 TypeError error when collection field changes (python3 only)
jpwatts · Jun 26, 2017 · 3e4bb6a · 3e4bb6a
2 parents b2efe57 + ac03d82
commit 3e4bb6a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/positions/fields.py b/positions/fields.py
@@ -93,13 +93,16 @@ def pre_save(self, model_instance, add):
             if updated is None:
                 updated = current
             current = None
-        #elif updated is None:
-        #    updated = -1
 
         # existing instance, position not modified; no cleanup required
         if current is not None and updated is None:
             return current
 
+        # if updated is still unknown set the object to the last position,
+        # either it is a new object or collection has been changed
+        if updated is None:
+            updated = -1
+
         collection_count = self.get_collection(model_instance).count()
         if current is None:
             max_position = collection_count